This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix windows build by removing sys-info #8860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't build for windows.
sakridge
force-pushed
the
fix-windows-build
branch
from
41b734c to
f792ef9
Compare
Codecov Report
@@ Coverage Diff @@
## master #8860 +/- ##
========================================
- Coverage 80.2% 80.2% -0.1%
========================================
Files 266 266
Lines 57609 57609
========================================
- Hits 46221 46217 -4
- Misses 11388 11392 +4 |
carllin
approved these changes
Mar 16, 2020
mvines
pushed a commit
to mvines/solana
that referenced
this pull request
Mar 20, 2020
Doesn't build for windows.
mvines
pushed a commit
to mvines/solana
that referenced
this pull request
Mar 20, 2020
Doesn't build for windows.
solana-grimes
pushed a commit
that referenced
this pull request
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
sys_info crate doesn't build on windows.
Summary of Changes
Remove it for the functionally equivalent num_cpus and gethostname.rs
Fixes #