-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instruction member function #8801
Merged
jackcmay
merged 2 commits into
solana-labs:master
from
jackcmay:instruction-member-function
Mar 12, 2020
Merged
Instruction member function #8801
jackcmay
merged 2 commits into
solana-labs:master
from
jackcmay:instruction-member-function
Mar 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Mar 12, 2020
sdk/src/instruction.rs
Outdated
@@ -201,6 +201,26 @@ impl CompiledInstruction { | |||
pub fn program_id<'a>(&self, program_ids: &'a [Pubkey]) -> &'a Pubkey { | |||
&program_ids[self.program_id_index as usize] | |||
} | |||
|
|||
/// Visit each unique instruction account index once | |||
pub fn visit_instruction_accounts_once( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visit_each_account()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Codecov Report
@@ Coverage Diff @@
## master #8801 +/- ##
========================================
- Coverage 79.9% 79.9% -0.1%
========================================
Files 261 261
Lines 56579 56598 +19
========================================
+ Hits 45227 45241 +14
- Misses 11352 11357 +5 |
This was referenced Apr 13, 2023
This was referenced Apr 15, 2023
This was referenced Apr 15, 2023
Open
Open
This was referenced Apr 18, 2023
Open
Open
This was referenced May 23, 2023
Open
Open
This was referenced May 29, 2023
Open
Open
This was referenced May 31, 2023
Open
This was referenced Jun 3, 2023
This was referenced Jun 3, 2023
Open
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
visit_instruction_accounts_once
is an Instruction specific function that may be used by others (and will be by cross-program-invocationsSummary of Changes
Make it a member function and add test
Fixes #