Remove --derivation-path option #8741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
added
automerge
Codecov Report
@@ Coverage Diff @@
## master #8741 +/- ##
========================================
- Coverage 79.9% 79.9% -0.1%
========================================
Files 261 261
Lines 56604 56572 -32
========================================
- Hits 45252 45222 -30
+ Misses 11352 11350 -2 |
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2020
automerge (cherry picked from commit 5fa397c)
solana-grimes
pushed a commit
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We added the
--derivation-pathoption before we added the?key=<DERIVATION_PATH>feature. The--derivation-pathoption is now redundant. It's also limited, as the option only applies to the keypair at--keypair. To be consistent, we'd need to add a second option for each keypair option.Summary of Changes
Remove
--derivation-path. Use?key=<DERIVATION_PATH>instead.