Maintenance : simplify a few patterns, remove unneeded dependencies #8137
Conversation
There was a problem hiding this comment.
Nice, that filter merging will probably have a positive performance impact. Need Rust to implement this: http://fun.cs.tufts.edu/stream-fusion.pdf
Only suggestion is generally to prefer the ? on Option instead of using map or and_then.
|
Can you run the build, such that the updated Cargo.lock is included in this PR? |
net-shaper: Removing log, semver, serde_derive bench-tps: Removing serde, serde_derive banking-bench: Removing solana ledger-tool: Removing bincode, serde, serde_derive librapay: Removing solana, language_e2e_tests log-analyzer: Removing log, semver, serde_derive exchange: Removing solana core: Removing crc, memmap, symlink, untrusted perf: Removing serde_derive genesis: Removing hex, serde_derive sdk-c: Removing sha2 sys-tuner: Removing semver bench-exchange: Removing bincode, bs58, env_logger, serde, serde_derive, untrusted, ws btc_spv_bin: Removing serde_json btc_spv: Removing chrono bpf_loader: Removing serde ledger: Removing dlopen, dlopen_derive, serde_derive move_loader: Removing byteorder, libc, language_e2e_tests ownable: Removing serde, serde_derive client: Removing rand archiver-utils: Removing rand_chacha validator: Removing serde_json, tempfile param_passing_dep: Removing solana failure: Removing log vest: Removing log vote-signer: Removing bs58, serde local-cluster: Removing symlink keygen: Removing rpassword install: Removing bs58, log upload-perf: Removing log runtime: Removing serde_json stake: Removing rand
|
Got a tool that spotted all the redundant crate dependencies? |
|
@garious Nope. I literally brute-forced them (remove one, try to see if it still works ..). |
Codecov Report
@@ Coverage Diff @@
## master #8137 +/- ##
========================================
+ Coverage 82% 82% +<.1%
========================================
Files 249 249
Lines 53542 53530 -12
========================================
- Hits 43916 43912 -4
+ Misses 9626 9618 -8 |
|
Thanks so much @huitseeker! A wonderful contribution! |
|
Lots of great cleanup, thanks! |
@huitseeker Nice work! I'm pretty amazed by such a great hard manual work. :) |
|
@ryoqun oh, I scripted the trial-and error, but that's just a couple lines of bash, and what you'd come up with is as good as what I did. Let me know if you want me to post this as a gist. |
dreams comes true: #31320 |
Opinions on the refactorings loosely held -> happy to accomodate in review
Problem
Summary of Changes
Fixes #