Factor out repair from gossip #8044
Conversation
core/src/serve_repair.rs
Outdated
| return None; | ||
| } | ||
|
|
||
| /*me.write() |
There was a problem hiding this comment.
@sagar-solana, this used to update on every repair request, I'm not sure if it's still necessary
There was a problem hiding this comment.
This just makes sure that we refresh the timestamps (liveness) of every value the from the repairee. We don't need to do it every time but we should update it at some cadence
There was a problem hiding this comment.
so it's essential repair updates this, gossip push/pull isn't enough?
There was a problem hiding this comment.
Not essential. I'm okay skipping it here.
| let value_size = value.size(); | ||
| let expected_len = NUM_VALUES / (MAX_PROTOCOL_PAYLOAD_SIZE / value_size).max(1) as usize; | ||
| let msgs = vec![value; NUM_VALUES]; | ||
| let num_values_per_payload = (MAX_PROTOCOL_PAYLOAD_SIZE / value_size).max(1); |
There was a problem hiding this comment.
@sagar-solana on test_split_messages_large, MAX_PROTOCOL_PAYLOAD_SIZE / value_size == 0, does that mean there are just some messages that are too large to fit in the payload?
There was a problem hiding this comment.
Yes, things like epoch_slots can grow too large.
carllin
force-pushed
the
FixClusterInfo
branch
from
4752d01 to
9a1c8d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #8044 +/- ##
========================================
- Coverage 81.9% 81.9% -0.1%
========================================
Files 244 249 +5
Lines 53316 53454 +138
========================================
+ Hits 43681 43784 +103
- Misses 9635 9670 +35 |
carllin
force-pushed
the
FixClusterInfo
branch
2 times, most recently
from
9a1c8d6 to
0aa652a
Compare
carllin
force-pushed
the
FixClusterInfo
branch
from
0aa652a to
b1f3011
Compare
This reverts commit e612576.
(cherry picked from commit d3712dd)
Problem
Repair is functionally and logically distinct from gossip, and does not need to be integrated into the same service.
Summary of Changes
Factor out serving repair from gossip
Testnet results here for before and after the change: https://metrics.solana.com:3000/d/testnet-edge/testnet-monitor-edge?orgId=2&from=1580415668783&to=1580419956328&var-datasource=Solana%20Metrics%20(read-only)&var-testnet=testnet-dev-carl&var-hostid=All&panelId=49
Fixes #