Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Update tiny_bip39 #7959

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

rob-solana
Copy link
Contributor

@rob-solana rob-solana commented Jan 24, 2020

Problem

mnemonic phrases need to be sanitized before being passed to bip39 library

Summary of Changes

update to bip39 that sanitizes mnemonic phrases

Fixes #7248

@rob-solana rob-solana added the automerge Merge this Pull Request automatically once CI passes label Jan 24, 2020
@solana-grimes solana-grimes merged commit d400a64 into solana-labs:master Jan 24, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #7959 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #7959   +/-   ##
======================================
  Coverage    81.9%   81.9%           
======================================
  Files         243     243           
  Lines       52609   52609           
======================================
  Hits        43116   43116           
  Misses       9493    9493

@rob-solana rob-solana deleted the Update-tiny_bip39 branch January 27, 2020 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solana-keygen crashes if seed phrase isn't sanitized
2 participants