Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce: Rename instructions with VerbNoun scheme #7775

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

t-nelson
Copy link
Contributor

@t-nelson t-nelson commented Jan 13, 2020

Problem

After move to system program, nonce instructions do not follow VerbNoun naming scheme

Summary of Changes

Rename them

@t-nelson t-nelson added the automerge Merge this Pull Request automatically once CI passes label Jan 13, 2020
@solana-grimes solana-grimes merged commit 81ae44f into solana-labs:master Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #7775 into master will increase coverage by <.1%.
The diff coverage is 96.4%.

@@           Coverage Diff            @@
##           master   #7775     +/-   ##
========================================
+ Coverage    81.8%   81.8%   +<.1%     
========================================
  Files         238     241      +3     
  Lines       50993   51020     +27     
========================================
+ Hits        41730   41761     +31     
+ Misses       9263    9259      -4

mergify bot pushed a commit that referenced this pull request Jan 13, 2020
automerge

(cherry picked from commit 81ae44f)

# Conflicts:
#	sdk/src/system_instruction.rs
t-nelson added a commit that referenced this pull request Jan 17, 2020
@t-nelson t-nelson deleted the rename_nonce_ix branch January 20, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants