-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book: Update durable nonce proposal entry #7694
Book: Update durable nonce proposal entry #7694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up making some overlapping suggestions. Let me know if anything doesn't make sense!
802a030
to
8bb41c6
Compare
Should all be addressed in 8bb41c6. Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the system program. This account will be in the `Uninitialized` state with no | ||
stored hash, and thus unusable. | ||
|
||
To initialize a newly created account, a `NonceInitialize` instruction must be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumping in late here, but was surprised to see the Nonce
prefix on every instruction. What's that about? No other program does that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prefixes were added when nonce was moved under the system program
automerge (cherry picked from commit ef06d16)
Problem
The durable nonce proposal entry no longer reflects the reality of its implementation
Summary of Changes
Adapt for:
Depends on #7684