Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book: Update durable nonce proposal entry #7694

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

t-nelson
Copy link
Contributor

@t-nelson t-nelson commented Jan 7, 2020

Problem

The durable nonce proposal entry no longer reflects the reality of its implementation

Summary of Changes

Adapt for:

  • Nonce now lives in system program
  • Runtime changes to prevent fee theft

Depends on #7684

@t-nelson t-nelson marked this pull request as ready for review January 10, 2020 23:58
@mvines mvines added the v0.22 label Jan 13, 2020
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up making some overlapping suggestions. Let me know if anything doesn't make sense!

book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
book/src/implemented-proposals/durable-tx-nonces.md Outdated Show resolved Hide resolved
@t-nelson
Copy link
Contributor Author

Should all be addressed in 8bb41c6. Thanks for the review!

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@t-nelson t-nelson added the automerge Merge this Pull Request automatically once CI passes label Jan 13, 2020
the system program. This account will be in the `Uninitialized` state with no
stored hash, and thus unusable.

To initialize a newly created account, a `NonceInitialize` instruction must be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumping in late here, but was surprised to see the Nonce prefix on every instruction. What's that about? No other program does that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefixes were added when nonce was moved under the system program

@solana-grimes solana-grimes merged commit ef06d16 into solana-labs:master Jan 13, 2020
mergify bot pushed a commit that referenced this pull request Jan 13, 2020
automerge

(cherry picked from commit ef06d16)
@t-nelson t-nelson deleted the book-sync-nonce-prop branch January 13, 2020 21:25
solana-grimes pushed a commit that referenced this pull request Jan 13, 2020
sakridge pushed a commit to sakridge/solana that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants