Use epoch as the gossip purge timeout for staked nodes. #7005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
changed the title
mergify
bot
dismissed
sagar-solana’s stale review
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #7005 +/- ##
========================================
- Coverage 79% 71.2% -7.8%
========================================
Files 225 227 +2
Lines 43369 48359 +4990
========================================
+ Hits 34279 34460 +181
- Misses 9090 13899 +4809 |
aeyakovenko
force-pushed
the
gossip_wait
branch
3 times, most recently
from
b463e02 to
e670bf6
Compare
aeyakovenko
force-pushed
the
gossip_wait
branch
from
4c8ae6e to
0ed4ec4
Compare
aeyakovenko
force-pushed
the
gossip_wait
branch
from
4a4a6b2 to
87152e2
Compare
* jemalloc heap memory tracker * gossip recycler fixes * partition test cleanup
aeyakovenko
force-pushed
the
gossip_wait
branch
from
87152e2 to
39d5c7d
Compare
aeyakovenko
added
the
automerge
aeyakovenko
added a commit
to aeyakovenko/solana
that referenced
this pull request
Nov 20, 2019
ryoqun
reviewed
Nov 21, 2019
| @@ -1385,6 +1385,7 @@ impl Bank { | |||
| /// A snapshot bank should be purged of 0 lamport accounts which are not part of the hash | |||
| /// calculation and could shield other real accounts. | |||
| pub fn verify_snapshot_bank(&self) -> bool { | |||
| self.purge_zero_lamport_accounts(); | |||
There was a problem hiding this comment.
@aeyakovenko Err, I think this should be removed because this is cherry-picked from #7010, which is not a correct fix (I'm working on it), and isn't related to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Gossip purge timeout is really short and will cause staked nodes to be purged during a relatively short partition.
Summary of Changes
Set the gossip timeout for staked nodes to be 1 epoch long.
Fixes #
tag: @sagar-solana