Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Upgrade xargo if old #6869

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

jackcmay
Copy link
Contributor

Problem

Install scripts only install xargo if xargo not already installed. If already installed the existing version will be used. The result is a mismatch of versions across installs that may not be compatible with the current SDK

Summary of Changes

Install xargo is not already installed or upgrade to latest if is

Fixes #

@jackcmay jackcmay merged commit 91cfa0a into solana-labs:master Nov 11, 2019
@jackcmay jackcmay deleted the xargo-versioning branch November 11, 2019 21:12
@CriesofCarrots
Copy link
Contributor

@jackcmay , is the nightly change necessary?
(I ask because it looks like it's breaking solana-web3.js CI: https://travis-ci.org/solana-labs/solana-web3.js?utm_medium=notificatioxn&utm_source=github_status)

@jackcmay
Copy link
Contributor Author

Bummer, the upgrade option is only available on nightly. The alternatives are either require nightly or do the "upgrade" manually (try install, check the version, force install if not latest). Not sure how to know the latest and don't want to force install every time a build is started...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants