This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Boot the Builder pattern from GenesisBlock #6364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rust's Builder pattern is an anti-pattern. We ran this experiment a while back with the
MessageBuilder
struct. It led to confusing code and redundant wrappers. It's especially ugly when you start using it in imperative code (let builder = builder.do_something()
). In the case ofGenesisBlock
, it went the same way.Summary of Changes
&mut self
methods to GenesisBlock that move their input parameters instead of cloning them. Use theT { field*, ..T::default() }
pattern.genesis()
to the form<verb>_<subject>
.