This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Replace unneeded seqcst with relaxed on atomic operations #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Jun 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #4587 +/- ##
=========================================
+ Coverage 66% 79.2% +13.1%
=========================================
Files 181 181
Lines 38726 32293 -6433
=========================================
+ Hits 25582 25584 +2
+ Misses 13144 6709 -6435 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4587 +/- ##
=========================================
+ Coverage 66% 79.2% +13.1%
=========================================
Files 181 181
Lines 38726 32293 -6433
=========================================
+ Hits 25582 25584 +2
+ Misses 13144 6709 -6435 |
|
@rob-solana, seeing seqcst implies an extra level of caution is needed when working with the code. There's also a small performance implication. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Seqcst is used in unneeded areas
Summary of Changes
Replace seqcst with relaxed
Fixes #