This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Lockfree #3961
Closed
Lockfree #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3961 +/- ##
========================================
+ Coverage 77.8% 77.9% +<.1%
========================================
Files 162 162
Lines 27522 27232 -290
========================================
- Hits 21425 21220 -205
+ Misses 6097 6012 -85 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3961 +/- ##
========================================
+ Coverage 77.8% 77.9% +<.1%
========================================
Files 162 162
Lines 27522 27232 -290
========================================
- Hits 21425 21220 -205
+ Misses 6097 6012 -85 |
ryoqun
pushed a commit
to ryoqun/solana
that referenced
this pull request
Dec 14, 2024
…olana-labs#3961) * make metrics configuration for gce sh more intuitive through improved documentation in Readme * Update net/init-metrics.sh script to address non-obvious interactions with scratch_writer. Co-authored-by: Illia Bobyr and Behzad Nouri
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3963
Problem
StorageEntry can't be removed from the storage map while appending.
Summary of Changes
Batch the appends in appendvec such that storage entry doesn't need a lock.
Fixes #