Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Unit tests for table mapping #3408

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

mark-solana
Copy link
Contributor

Problem

See #3407

Summary of Changes

Add unit tests for table mappers
Fix bug in disk mapper uncovered by tests
Use tempdir crate for unit-tests

Fixes #3407

add tests to `kvstore::mapper::{disk, memory}` modules

fix bug in disk mapper uncovered by tests

use `tempdir` crate for unit test-directories
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #3408 into master will increase coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3408    +/-   ##
=======================================
+ Coverage    80.2%   81.2%    +1%     
=======================================
  Files         153     153            
  Lines       22555   22679   +124     
=======================================
+ Hits        18095   18438   +343     
+ Misses       4460    4241   -219

Copy link
Contributor

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging #3408 into master will increase coverage by 1%.

🎉

@mark-solana mark-solana merged commit 9b0bf5a into solana-labs:master Mar 21, 2019
@mark-solana mark-solana deleted the kvstore.mapper branch April 3, 2019 03:06
joncinque pushed a commit to joncinque/solana that referenced this pull request Nov 20, 2024
* extract keccak-hasher crate

* fix lint

* sort deps

* missing feature

* update lock file

* remove unused deps

* make std optional
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants