This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
[zk-token-sdk] Check that discrete log compression batch size is greater than 0 #33699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33699 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 806 806
Lines 218058 218106 +48
=========================================
+ Hits 178415 178453 +38
- Misses 39643 39653 +10 |
samkim-crypto
added
v1.17
CriesofCarrots
approved these changes
Oct 24, 2023
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…is greater than 0 (backport of solana-labs#33699) (solana-labs#33844) [zk-token-sdk] Check that discrete log compression batch size is greater than 0 (solana-labs#33699) check that discrete log compression batch size is greater than 0 (cherry picked from commit 381d225) Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…is greater than 0 (backport of solana-labs#33699) (solana-labs#33844) [zk-token-sdk] Check that discrete log compression batch size is greater than 0 (solana-labs#33699) check that discrete log compression batch size is greater than 0 (cherry picked from commit 381d225) Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#33506
Summary of Changes
Add a check on
compression_batch_sizein the discrete logic so that the program errors gracefully.Fixes #