This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
v1.17: skip unrecognized keys in Blockstore special-column iterators #33617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 9, 2023 22:19
Codecov Report
@@ Coverage Diff @@
## v1.17 #33617 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 804 804
Lines 217987 218002 +15
=========================================
- Hits 178319 178280 -39
- Misses 39668 39722 +54 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In v1.18, #33419 will deprecate the existing special-column keys, and start using new ones without the primary indexes. We want nodes to be able to upgrade and downgrade between minor releases as needed. But currently, when a node hits a key of the wrong length, it will panic.
Summary of Changes
Add a very abbreviated version of the ColumnIndexDeprecation trait to enable the
LedgerColumn::iter_current_index_filtered()methodImplement ColumnIndexDeprecation for the TransactionStatus and AddressSignatures columns. (While #33419 also implements the trait for the TransactionMemo column, there isn't anywhere calling the
iter()method against that column, so nothing that will panic on the new keys.)