This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Clean up locks in KvStore #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit is now an AtomicUsize In-memory table and write-log are now struct members behind individual RwLocks
Codecov Report
@@ Coverage Diff @@
## master #3358 +/- ##
========================================
- Coverage 78.5% 78.2% -0.4%
========================================
Files 154 151 -3
Lines 22195 21773 -422
========================================
- Hits 17439 17039 -400
+ Misses 4756 4734 -22 |
|
I'm going to merge this without review as it doesn't contain any substantive changes and is blocking other things. |
bw-solana
pushed a commit
to bw-solana/solana
that referenced
this pull request
Oct 29, 2024
alessandrod
pushed a commit
to alessandrod/solana
that referenced
this pull request
Nov 5, 2024
…lana-labs#3358) (solana-labs#3363) add missing description for solana-lattice-hash (solana-labs#3358) (cherry picked from commit 51a114e) Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See Issue #3352
Summary of Changes
Delete
WriteStatestruct and implement functionality in freefnsMove commit to an AtomicUsize in
KvStoreMove in-memory table to
KvstoreRemove locks from
WriteLogand putWriteLogbehind anArc<RwLock<T>>inKvStoreFixes #3352