Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

add Restart structs for disk index #33361

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

Working on improving startup time.
Working towards re-using disk index files on restart instead of creating new ones.

Summary of Changes

Add Restart and a few other structs to keep track of the current file name and random used by individual disk buckets.

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review September 21, 2023 22:22
@jeffwashington jeffwashington assigned HaoranYi and unassigned HaoranYi Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #33361 (c42c1a1) into master (3e8ccbe) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 77.3%.

@@           Coverage Diff            @@
##           master   #33361    +/-   ##
========================================
  Coverage    81.9%    81.9%            
========================================
  Files         796      797     +1     
  Lines      215842   215987   +145     
========================================
+ Hits       176910   177042   +132     
- Misses      38932    38945    +13     

Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

bucket_map/src/restart.rs Show resolved Hide resolved
@jeffwashington jeffwashington merged commit 97d53be into solana-labs:master Sep 22, 2023
SwenSchaeferjohann pushed a commit to ananas-block/solana that referenced this pull request Sep 23, 2023
Switch confirmed_unrooted_slots from Vec<_> to HashSet<_> (solana-labs#33311)

The container is only used to check for inclusion of slots with
the .contains() method. This method is O(n) on a Vec<_> but O(1) on a
HashSet<_>.

add Restart structs for disk index (solana-labs#33361)

use bytemuck for disk bucket restart (solana-labs#33371)

disk bucket: init restart path (solana-labs#33375)

simple cleanup in bucket map (solana-labs#33376)

add disk bucket get_restart_file (solana-labs#33373)

* add disk bucket get_restart_file

* add get_restartable_buckets

pass RestartableBucket through disk index (solana-labs#33377)

data bucket holds RestartableBucket (solana-labs#33381)

Feature - better error codes for tx lamport check (solana-labs#33343)

Replaces `TransactionError::InstructionError(0, InstructionError::UnbalancedInstruction)` with `TransactionError::UnbalancedTransaction`.

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>

DiskIdx: reuse disk bucket file if possible (solana-labs#33379)

diskidx: stats for created vs reused (solana-labs#33385)

solana-program - altbn128: add g1 & g2 compression

still fixing tests for point of infinity

feat: proof compression syscall working

add rust test to ci

remove prints

added c test

added sycall pricing

fixed ci checks

refactored altbn128 and compression
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants