This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
removes outdated matches crate from dependencies #33172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
rm-matches
branch
2 times, most recently
from
cdb1ac2 to
c0f20b9
Compare
std::matches has been stable since rust 1.42.0. Other use-cases are covered by assert_matches crate.
behzadnouri
force-pushed
the
rm-matches
branch
from
c0f20b9 to
f780a47
Compare
Codecov Report
@@ Coverage Diff @@
## master #33172 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 785 785
Lines 211205 211205
=========================================
- Hits 173432 173415 -17
- Misses 37773 37790 +17 |
CriesofCarrots
approved these changes
Sep 7, 2023
| @@ -5737,7 +5738,6 @@ dependencies = [ | |||
| "lazy_static", | |||
| "log", | |||
| "lru", | |||
| "matches", | |||
There was a problem hiding this comment.
It's a pity this doesn't actually remove matches from our lock file. Looks like it's being kept around because of jsonrpc pulling in an old url crate. I'm looking into whether there's anything to be done about that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
std::matcheshas been stable since rust 1.42.0.Other use-cases are covered by
assert_matchescrate.Summary of Changes
removed matches crate from dependencies.