This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Renames AccountsPackageType to AccountsPackageKind #32908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When creating an enum to select some underlying kind of a thing, we sometimes append
Enum
orType
for the name of the type. I think both of these are bad, but not life ending.Obviously the variants are not types in the Rust sense of the word. And the type is already an enum, so adding
Enum
feels redundant.In the Rust std lib, they have this problem for errors. They've solved this with
ErrorKind
.(Some non-Rust projects have also used
Flavor
too, which I like, but not as much asKind
.)AccountsPackageType
has this naming problem.Summary of Changes
Rename
AccountsPackageType
toAccountsPackageKind
.