This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
client: Rename confrim -> confirm #32861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32861 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 785 785
Lines 212412 212412
=========================================
- Hits 174212 174203 -9
- Misses 38200 38209 +9 |
|
Nice catch #32638 may make this PR not compilable. |
godmodegalactus
approved these changes
Aug 17, 2023
KirillLykov
approved these changes
Aug 17, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 21, 2023
* client: Rename confrim -> confirm * Rebase fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While looking over changes in #32638, I noticed some typos of
confriminSendAndConfrimConfigandsend_and_confrim_transactions_in_parallel.rsSummary of Changes
Fix the typos! This can go in after #32638 since that's been approved.
Fixes #