Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

ci: fix cc only support unix and window since 1.0.80 #32689

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

yihau
Copy link
Contributor

@yihau yihau commented Aug 2, 2023

Problem

we bumped cc to 1.0.80 in #32681 and it only supports unix and window atm.

https://github.com/rust-lang/cc-rs/blob/7adebb9d8c235a53800c4ac3a160615aa1c5028c/src/os_pipe.rs#L19-L28

#[cfg(unix)]
#[path = "os_pipe/unix.rs"]
mod sys;

#[cfg(windows)]
#[path = "os_pipe/windows.rs"]
mod sys;

#[cfg(all(not(unix), not(windows)))]
compile_error!("Only unix and windows support os_pipe!");

Summary of Changes

update our Cargo.toml to fit the requirement

@yihau yihau requested a review from behzadnouri August 2, 2023 15:58
@yihau yihau marked this pull request as ready for review August 2, 2023 15:59
@yihau yihau added the automerge Merge this Pull Request automatically once CI passes label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #32689 (953771c) into master (67b2f89) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #32689     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         785      785             
  Lines      211067   211067             
=========================================
- Hits       173151   173148      -3     
- Misses      37916    37919      +3     

@mergify mergify bot merged commit 4dc6eb1 into solana-labs:master Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants