introduce SerializedAccountMetadata #32644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32644 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 785 785
Lines 211023 211036 +13
=======================================
+ Hits 173094 173124 +30
+ Misses 37929 37912 -17 |
alessandrod
force-pushed
the
cpi-serialized-account-metadata
branch
from
2dfc0e5 to
0133a1a
Compare
…paramters_(aligned|unaligned) This is in preparation of returning more than just the original length
…f a slice This is in preparation of extracting account lenghts from a larger context
Instead of passing original_account_lengths around as Vec<usize>, introduce an explicit type that includes the length and soon more.
alessandrod
force-pushed
the
cpi-serialized-account-metadata
branch
2 times, most recently
from
3337ebd to
07257aa
Compare
Lichtso
approved these changes
Jul 28, 2023
ryoqun
reviewed
Jul 31, 2023
| transaction_context: &TransactionContext, | ||
| instruction_context: &InstructionContext, | ||
| copy_account_data: bool, | ||
| buffer: &[u8], | ||
| account_lengths: &[usize], | ||
| account_lengths: I, |
There was a problem hiding this comment.
nit: i prefer existential types for these cases for one less type parameter (slight readability improvement, imo):
account_lengths: impl IntoIterator<Item = usize>,
ryoqun
reviewed
Jul 31, 2023
| .map(|instruction_account_index| { | ||
| if let Some(index) = instruction_context | ||
| .is_instruction_account_duplicate(instruction_account_index) | ||
| .unwrap() |
There was a problem hiding this comment.
(note to self) seems this and below new .unwrap()s are safe. i.e. these are always infallible before/after this pr.
ryoqun
reviewed
Aug 1, 2023
Comment on lines
+215
to
+218
| // fun fact: jemalloc is good at caching tiny allocations like this one, | ||
| // so collecting here is actually faster than passing the iterator | ||
| // around, since the iterator does the work to produce its items each | ||
| // time it's iterated on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing
original_account_lengthsaround asVec<usize>, introduce an explicit type that includes the length and soon more. Doesn't change anything in the existing logic, just the type passed around.Extracted from #31986. This is preparation of passing around more data from serialization down to CPI.