This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Define ClusterConfig::new_with_equal_stakes() #32330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #32330 +/- ##
=======================================
Coverage 82.0% 82.1%
=======================================
Files 773 773
Lines 209748 209748
=======================================
+ Hits 172180 172216 +36
+ Misses 37568 37532 -36 |
apfitzge
reviewed
Jun 29, 2023
| @@ -93,6 +93,25 @@ pub struct ClusterConfig { | |||
| pub tpu_connection_pool_size: usize, | |||
| } | |||
|
|
|||
| impl ClusterConfig { | |||
| pub fn new_with_equal_stakes( | |||
There was a problem hiding this comment.
does / should this be pub?
There was a problem hiding this comment.
seems so... even pub(crate) didn't work (tested at #31239):
error[E0624]: associated function `new_with_equal_stakes` is private
--> local-cluster/tests/local_cluster.rs:3038:37
|
3038 | let mut config = ClusterConfig::new_with_equal_stakes(
| ^^^^^^^^^^^^^^^^^^^^^ private associated function
|
::: /home/ryoqun/work/solana/for-merge/local-cluster/src/local_cluster.rs:96:5
|
96 | / pub(crate) fn new_with_equal_stakes(
97 | | num_nodes: usize,
98 | | cluster_lamports: u64,
99 | | lamports_per_node: u64,
100 | | ) -> Self {
| |_____________- private associated function defined here
For more information about this error, try `rustc --explain E0624`.
error: could not compile `solana-local-cluster` (test "local_cluster") due to previous error
warning: build failed, waiting for other jobs to finish...
local-cluster/src/local_cluster.rs
Outdated
Comment on lines
102
to
104
| let stakes: Vec<_> = vec![lamports_per_node; num_nodes]; | ||
| Self { | ||
| node_stakes: stakes, |
There was a problem hiding this comment.
realize it was just moved, but let's do a tactical rename in this PR:
Suggested change
| let stakes: Vec<_> = vec![lamports_per_node; num_nodes]; | |
| Self { | |
| node_stakes: stakes, | |
| let node_stakes = vec![lamports_per_node; num_nodes]; | |
| Self { | |
| node_stakes, |
There was a problem hiding this comment.
how about this? 0d5e602 better, imo. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
another small refactor for #31239 per #31239 (comment)
Summary of Changes
Fixes #