This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
require repair request signature #31888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31888 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 764 764
Lines 208095 208085 -10
=========================================
- Hits 170573 170464 -109
- Misses 37522 37621 +99 |
jbiseda
force-pushed
the
repair-require-signed-requests
branch
from
4bde894 to
e18e238
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
(cherry picked from commit b06df6a)
jbiseda
added a commit
that referenced
this pull request
Jun 13, 2023
jeffwashington
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Jun 13, 2023
wen-coding
added a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Signed repair requests are not required on all cluster types. Versions prior to 1.13.6 do not send signed repair requests. Once the cluster validator floor version is at least 1.13.6, repair requests should be required to be signed.
Summary of Changes
Remove
ClusterTypegating for signed repair requests.Fixes #