Reverify programs that are extended using ExtendProgram

[pgarg66]

Problem

The programs extended via ExtendProgram instruction need re-verification, as the updated program may return different verification result than the original program.

Summary of Changes

• Compile and verify the program with the extended size
• Add a cooldown of 1 slot to prevent repeated extension of the program in the same slot
• Add a new unit test for the cooldown
• Update existing tests to deploy a program and extend it

Fixes #

[codecov]

Codecov Report

Merging #31886 (034ed90) into master (8203c6e) will decrease coverage by 0.1%.
The diff coverage is 78.7%.

@@            Coverage Diff            @@
##           master   #31886     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         752      753      +1     
  Lines      206799   206885     +86     
=========================================
+ Hits       169480   169501     +21     
- Misses      37319    37384     +65     

[Lichtso]

Maybe we should actually perform the verification / compilation inside the instruction (like we do for upgrades) so that it can fail the TX if the verification fails.

[jstarry]

Note that since this change now updates the program data clock slot, it's no longer possible to extend and update a program in the same slot (or transaction for that matter). I don't think it's a great dev experience that two separate transactions will need to be created for program upgrades but the extend program instruction is still an improvement over the current dev experience so I think it's ok for now.

[jstarry]

I think new_len should already be the full account size, why is size_of_program added here as well?

[Lichtso]

I think you are right, this is a bug, probably copy pasta.
A fix should be backported before the feature is activated.

@pgarg66 Thoughts?

[Lichtso]

Taking it back, this is correct behavior (consistent with v1.14). This is the sum of the proxy account plus the data account. The value is used in transaction loading for the TX wide loading limit and both accounts contribute to that.

https://github.com/pgarg66/solana/blob/034ed90aca470fbde2719e982b5b13d0680876e2/runtime/src/accounts.rs#L400