Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

update comment for clarification #31700

Merged
merged 1 commit into from
May 18, 2023
Merged

update comment for clarification #31700

merged 1 commit into from
May 18, 2023

Conversation

tao-stones
Copy link
Contributor

Problem

Clarify a comment

Summary of Changes

  • update comment

Fixes #

@tao-stones tao-stones mentioned this pull request May 17, 2023
Merged
apfitzge
apfitzge reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31671 (comment)

Depending on if builtin stuff is changed or not, this comment clarification may change.

@tao-stones tao-stones requested a review from apfitzge May 17, 2023 21:55
@tao-stones
Copy link
Contributor Author

#31671 (comment)

Depending on if builtin stuff is changed or not, this comment clarification may change.

Intentionally use "execution cost" to cover both "builtin execution cost" and "bpf execution cost".

Side note, just browsing code, will start with removing BUILT_IN_INSTRUCTION_COSTS first. PR coming up soon

apfitzge
apfitzge approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tao-stones tao-stones merged commit 039991e into solana-labs:master May 18, 2023
@tao-stones tao-stones deleted the refactor-update-comment branch May 18, 2023 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apfitzge apfitzge apfitzge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tao-stones @apfitzge