This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
default to using packed ancient append vec #31657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31657 +/- ##
=======================================
Coverage 81.2% 81.3%
=======================================
Files 736 736
Lines 207455 207455
=======================================
+ Hits 168658 168674 +16
+ Misses 38797 38781 -16 |
yhchiang-sol
approved these changes
May 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Switch to using packed ancient storages instead of appended ancient storages.
This has been thoroughly tested against mnb, kin, including with 300k slots INTO the current epoch against mnb.
We can remove the append code at some point soon.
Summary of Changes
This should have no effect except during testing until we enable the eliminate rewrites feature.
Fixes #