derive TransactionCost::{PartialEq, Eq}

[apfitzge]

Problem

Writing tests for these is pretty inconvenient w/o equal comparison.
Was in the process of adding some more tests to QosService after #31542 when I encountered this

Summary of Changes

derive PartialEq and Eq

Fixes #

[codecov]

Codecov Report

Merging #31626 (8fdb16e) into master (91194cd) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

@@            Coverage Diff            @@
##           master   #31626     +/-   ##
=========================================
- Coverage    81.3%    81.2%   -0.1%     
=========================================
  Files         733      733             
  Lines      206666   206679     +13     
=========================================
- Hits       168038   168030      -8     
- Misses      38628    38649     +21     

[tao-stones]

not sure if the default impl compares writable_accounts correctly - only the content of vec matters, not the order.

[apfitzge]

not sure if the default impl compares writable_accounts correctly - only the content of vec matters, not the order.

🤔 yeah, I guess that is true. For my test cases I was always getting the costs from the same transactions so order was equivalent.

I think it should only be used in tests, so I'm happy to write a custom one that checks contents instead of directly Vecs.

[tao-stones]

not sure if the default impl compares writable_accounts correctly - only the content of vec matters, not the order.

🤔 yeah, I guess that is true. For my test cases I was always getting the costs from the same transactions so order was equivalent.

I think it should only be used in tests, so I'm happy to write a custom one that checks contents instead of directly Vecs.

Yeah, i think it's ok to use default impl for test. I guess don't really need "deep" compare in regular code?

[tao-stones]

lgtm