This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
runtime: transpose VoteAccount::vote_state() return to improve ergonomics
#31256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
reviewed
Apr 18, 2023
| @@ -65,12 +65,13 @@ impl VoteAccount { | |||
| self.0.account.owner() | |||
| } | |||
|
|
|||
| pub fn vote_state(&self) -> &Result<VoteState, Error> { | |||
| pub fn vote_state(&self) -> Result<&VoteState, &Error> { | |||
There was a problem hiding this comment.
I guess the tradeoff is that this return type is ugly/weird.
Is the .as_ref() at call-sites really a big deal?
There was a problem hiding this comment.
i would argue that &Result<T, E> is uglier than Result<&T, &E>. we prefer Option<&T> to &Option<T> in most cases elsewhere to avoid the eye-twitch-inducing &None. ofc, this would all be better if it were Result<&T, E>, but i don't think we can get to that without jumping through hoops
behzadnouri
reviewed
Apr 18, 2023
behzadnouri
approved these changes
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #31256 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 729 729
Lines 206621 206622 +1
=======================================
+ Hits 168484 168525 +41
+ Misses 38137 38097 -40 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VoteAccount::vote_state()returns an&Result<..., forcing every call site to.as_ref()et. all on use.Summary of Changes
internally transpose the referencing. clean up call sites
this was very satisfying. i wish i'd caught it on review 😅