This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
[docs] clarify logsSubscribe mentions param
#31225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tyera <teulberg@gmail.com>
Co-authored-by: Tyera <teulberg@gmail.com>
CriesofCarrots
approved these changes
Apr 17, 2023
nickfrosty
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
* fix: clarify logsSubscribe mentions param * Update docs/src/api/websocket/_logsSubscribe.mdx Co-authored-by: Tyera <teulberg@gmail.com> * Update docs/src/api/websocket/_logsSubscribe.mdx Co-authored-by: Tyera <teulberg@gmail.com> --------- Co-authored-by: Tyera <teulberg@gmail.com> (cherry picked from commit 26bec21)
jacobcreech
pushed a commit
that referenced
this pull request
Apr 18, 2023
) (#31229) [docs] clarify logsSubscribe `mentions` param (#31225) * fix: clarify logsSubscribe mentions param * Update docs/src/api/websocket/_logsSubscribe.mdx Co-authored-by: Tyera <teulberg@gmail.com> * Update docs/src/api/websocket/_logsSubscribe.mdx Co-authored-by: Tyera <teulberg@gmail.com> --------- Co-authored-by: Tyera <teulberg@gmail.com> (cherry picked from commit 26bec21) Co-authored-by: Nick Frostbutter <75431177+nickfrosty@users.noreply.github.com>
bw-solana
pushed a commit
to bw-solana/solana
that referenced
this pull request
Jan 10, 2025
…ana-labs#31225) (solana-labs#31229) [docs] clarify logsSubscribe `mentions` param (solana-labs#31225) * fix: clarify logsSubscribe mentions param * Update docs/src/api/websocket/_logsSubscribe.mdx Co-authored-by: Tyera <teulberg@gmail.com> * Update docs/src/api/websocket/_logsSubscribe.mdx Co-authored-by: Tyera <teulberg@gmail.com> --------- Co-authored-by: Tyera <teulberg@gmail.com> (cherry picked from commit 26bec21) Co-authored-by: Nick Frostbutter <75431177+nickfrosty@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
logsSubscribewebsocket method'smentionsparameter has confusing language about how many addresses should be supplied.Summary of Changes
added clarifying text and
cautionbox about the logsSubscribe'smentionsparameterFixes #31217