This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
chore: workspace inheritance #30939
Merged
chore: workspace inheritance #30939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30939 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 727 727
Lines 205250 205250
=========================================
- Hits 167430 167424 -6
- Misses 37820 37826 +6 |
t-nelson
approved these changes
Mar 29, 2023
Comment on lines
-14
to
-15
| serde = { version = "1.0.112", features = ["derive"] } | ||
| serde_json = "1.0.56" |
There was a problem hiding this comment.
both of these will be updated by moving to the workspace version. probably not a problem, just wanted to raise
CriesofCarrots
approved these changes
Mar 29, 2023
|
Whoa, TIL you can set automerge before you actually receive review approval. |
same! got scared for a second that i'd merged it by accident 😅 |
|
can't remember who is the first one use this but it is really useful 😈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some crates don't use workspace inheritance
Summary of Changes
make them use it ⛏️