This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
removes wallclock from duplicate-shreds handler #30187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate-shred handler relies on all chunks within a duplicate-shred proof having the same wallclock. But this is only an implementation detail and does not need to be the case.
behzadnouri
force-pushed
the
dup-shred-wallclock
branch
from
42c4e3e to
d409119
Compare
wen-coding
reviewed
Feb 8, 2023
wen-coding
approved these changes
Feb 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
(cherry picked from commit 544fbde)
behzadnouri
added a commit
that referenced
this pull request
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Duplicate-shred handler relies on all chunks within a duplicate-shred proof having the same wallclock. But this is only an implementation detail and does not need to be the case.
Summary of Changes
Removed wallclock from duplicate-shreds handler.