This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Bugfix: bank-hash optionally takes halt_at_slot #29865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about wiring up |
apfitzge
force-pushed
the
bugfix/ledger_tool-bank_hash
branch
from
0f80668 to
169d592
Compare
apfitzge
changed the title
Haha you read my mind right after I pushed this. I did just that, and similarly for the shred-version subcommand in #29870 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
bank-hashsubcommand setshalt_at_slotto 0 which goes against the meaning ofhalt_at_slot, as well as not doing what the description ofbank-hashdoes: "Prints the hash of the working bank after reading the ledger".Summary of Changes
Don't set
halt_at_slotforbank-hashsubcommand.Fixes #29799