Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Special case slot 0 for block connectness check in ledger tool #29860

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Special case slot 0 for block connectness check in ledger tool #29860

merged 6 commits into from
Jan 25, 2023

Conversation

HaoranYi
Copy link
Contributor

@HaoranYi HaoranYi commented Jan 24, 2023 •
edited
Loading

Problem

Fix #29799

Summary of Changes

Special case slot 0 for block connectness check.

Fixes #

@HaoranYi HaoranYi mentioned this pull request Jan 24, 2023
Closed
@mvines
Copy link
Contributor

mvines commented Jan 24, 2023

Probably want to remove "filter stake by min delegation for rewards" from here!

@apfitzge apfitzge mentioned this pull request Jan 24, 2023
Closed
@HaoranYi HaoranYi changed the title Allow ledger tool to process slot immediate after genesis (slot 0) Special case slot 0 for block connectness check in ledger tool Jan 24, 2023
@HaoranYi HaoranYi requested review from steviez and apfitzge January 24, 2023 23:02
apfitzge
apfitzge reviewed Jan 24, 2023
View reviewed changes
ledger-tool/src/main.rs Outdated Show resolved Hide resolved
apfitzge
apfitzge reviewed Jan 24, 2023
View reviewed changes
ledger-tool/src/main.rs Outdated Show resolved Hide resolved
steviez
steviez reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tweaks on the comments. Agreed with Andrew on the code; my mind didn't make the jump to do match here and it is cleaner than the nested if's I would have coded up

ledger-tool/src/main.rs Outdated Show resolved Hide resolved
ledger-tool/src/main.rs Outdated Show resolved Hide resolved
HaoranYi and others added 2 commits January 24, 2023 20:44
@HaoranYi
Update ledger-tool/src/main.rs
2e9f824 
Co-authored-by: steviez <steven@solana.com>
@HaoranYi
Update ledger-tool/src/main.rs
a7d13d0 
Co-authored-by: steviez <steven@solana.com>
apfitzge
apfitzge approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HaoranYi HaoranYi merged commit 2194551 into solana-labs:master Jan 25, 2023
@HaoranYi HaoranYi deleted the jan_24 branch January 25, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steviez steviez steviez approved these changes

@apfitzge apfitzge apfitzge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

solana-ledger-tool errors with Unable to load bank forks at slot 0 due to disconnected blocks.
4 participants
@HaoranYi @mvines @steviez @apfitzge