Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

faucet: Expose time-slice, per-time-cap, and per-request-cap in test validator #29812

Merged
merged 1 commit into from
Jan 21, 2023
Merged

faucet: Expose time-slice, per-time-cap, and per-request-cap in test validator #29812

merged 1 commit into from
Jan 21, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Jan 21, 2023

Problem

Some of the faucet flags are not present in the test-validator.

Summary of Changes

Expose more of the faucet flags in the test-validator. I kept these in SOL to keep this consistent with the faucet-sol flag.

@mergify mergify bot added the community Community contribution label Jan 21, 2023
@mergify mergify bot requested a review from a team January 21, 2023 01:02
@mvines mvines added the CI Pull Request is ready to enter CI label Jan 21, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Jan 21, 2023
Copy link
Contributor

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the PR!

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Jan 21, 2023
@mvines mvines merged commit f4339bc into solana-labs:master Jan 21, 2023
@kevinji kevinji deleted the add-faucet-flags branch January 21, 2023 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants