This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
deprecates Pubkey::new in favor of Pubkey::{,try_}from #29805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
deprecate-pubkey-new
branch
2 times, most recently
from
caa599c to
bb35857
Compare
behzadnouri
changed the title
behzadnouri
force-pushed
the
deprecate-pubkey-new
branch
from
d843666 to
851dc8a
Compare
The commit deprecates Pubkey::new which lacks type-safety and instead implements TryFrom<&[u8]> and TryFrom<Vec<u8>> for Pubkey.
t-nelson
previously approved these changes
Jan 21, 2023
behzadnouri
force-pushed
the
deprecate-pubkey-new
branch
from
851dc8a to
1c9483c
Compare
behzadnouri
changed the title
mergify
bot
dismissed
t-nelson’s stale review
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2023
The commit deprecates Pubkey::new which lacks type-safety and instead implements TryFrom<&[u8]> and TryFrom<Vec<u8>> for Pubkey. (cherry picked from commit 272e667) # Conflicts: # runtime/src/accounts_db.rs # runtime/src/accounts_hash.rs # runtime/src/ancient_append_vecs.rs # runtime/src/append_vec.rs # runtime/src/bank.rs # runtime/src/storable_accounts.rs # streamer/src/tls_certificates.rs # transaction-status/src/parse_instruction.rs
behzadnouri
added a commit
that referenced
this pull request
Jan 24, 2023
…) (#29816) * deprecates Pubkey::new in favor of Pubkey::{,try_}from (#29805) The commit deprecates Pubkey::new which lacks type-safety and instead implements TryFrom<&[u8]> and TryFrom<Vec<u8>> for Pubkey. (cherry picked from commit 272e667) # Conflicts: # runtime/src/accounts_db.rs # runtime/src/accounts_hash.rs # runtime/src/ancient_append_vecs.rs # runtime/src/append_vec.rs # runtime/src/bank.rs # runtime/src/storable_accounts.rs # streamer/src/tls_certificates.rs # transaction-status/src/parse_instruction.rs * resolves mergify merge conflicts * bumps solana_bpf_rust_sanity Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pubkey::newlacks type safety.Summary of Changes
The commit deprecates
Pubkey::newand instead implementsTryFrom<&[u8]>andTryFrom<Vec<u8>>forPubkey.