Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Clean up: banking_stage_prepare_sanitized_batch #28841

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions core/src/banking_stage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1507,9 +1507,9 @@ impl BankingStage {
// Only lock accounts for those transactions are selected for the block;
// Once accounts are locked, other threads cannot encode transactions that will modify the
// same account state
let mut lock_time = Measure::start("lock_time");
let batch = bank.prepare_sanitized_batch_with_results(txs, transactions_qos_results.iter());
lock_time.stop();
let (batch, lock_time) = measure!(
bank.prepare_sanitized_batch_with_results(txs, transactions_qos_results.iter())
);

// retryable_txs includes AccountInUse, WouldExceedMaxBlockCostLimit
// WouldExceedMaxAccountCostLimit, WouldExceedMaxVoteCostLimit
Expand All @@ -1524,10 +1524,8 @@ impl BankingStage {
log_messages_bytes_limit,
);

let mut unlock_time = Measure::start("unlock_time");
// Once the accounts are new transactions can enter the pipeline to process them
drop(batch);
unlock_time.stop();
let (_, unlock_time) = measure!(drop(batch));

let ExecuteAndCommitTransactionsOutput {
ref mut retryable_transaction_indexes,
Expand Down