enable repair ping/pong cache #28408
Conversation
core/src/serve_repair.rs
Outdated
| fn uses_ping_cache_check(request: &RepairProtocol) -> bool { | ||
| match request { | ||
| RepairProtocol::LegacyWindowIndex(_, _, _) | ||
| | RepairProtocol::LegacyHighestWindowIndex(_, _, _) | ||
| | RepairProtocol::LegacyOrphan(_, _) | ||
| | RepairProtocol::LegacyWindowIndexWithNonce(_, _, _, _) | ||
| | RepairProtocol::LegacyHighestWindowIndexWithNonce(_, _, _, _) | ||
| | RepairProtocol::LegacyOrphanWithNonce(_, _, _) | ||
| | RepairProtocol::LegacyAncestorHashes(_, _, _) |
There was a problem hiding this comment.
Why shouldn't it do ping/pong check for legacy requests?
There was a problem hiding this comment.
Legacy requests should be removed when ping/pong verification is required. I don't see the need to extend it to legacy types now.
There was a problem hiding this comment.
What is the downside of requiring ping/pong for legacy requests as well?
I think it would be much simpler if we don't tie ping/pong and signed requests together, or add a dependency between the two. These two seem to me separate independent things.
There was a problem hiding this comment.
changed to apply to legacy requests
v1.10.38, v1.13.0, v1.14.1 all process ping/pong requests. This should cover 100% of mainnet stake and 99% of mainnet rpc. |
jbiseda
force-pushed
the
reenable-repair-ping-pong
branch
from
9daca5b to
66397d2
Compare
(cherry picked from commit 0df4be0)
(cherry picked from commit 0df4be0)
Problem
reenable ping/pong support for repair requests.
Summary of Changes
Enable ping creation/verification for repair requests.
See #27910 for reference.
Fixes #