This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Move test_replay to integration tests #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test passes consistently when the test suite is run with a single thread. It fails consistently on MacOS when run as part of the unit-test suite. No idea why it passes in CI.
garious
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
========================================
- Coverage 78.6% 78.4% -0.3%
========================================
Files 125 125
Lines 19597 19494 -103
========================================
- Hits 15408 15286 -122
- Misses 4189 4208 +19 |
joncinque
pushed a commit
to joncinque/solana
that referenced
this pull request
Sep 4, 2024
* refactor `impl_from_str` and `impl_from_bytes` macros * impl `Display`, `FromStr`, `From<[u8; _]>` for sigma and range proof pod types * impl `Display` for Pedersen commitment and grouped ElGamal ciphertext pod types * impl `Display`, `FromStr`, `From<[u8; _]>` for decrypt handle pod type * add fixed proof string tests * cargo clippy * remove println's * update `assert!` and `.is_ok()` with `unwrap`'s
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Sep 4, 2024
* refactor `impl_from_str` and `impl_from_bytes` macros * impl `Display`, `FromStr`, `From<[u8; _]>` for sigma and range proof pod types * impl `Display` for Pedersen commitment and grouped ElGamal ciphertext pod types * impl `Display`, `FromStr`, `From<[u8; _]>` for decrypt handle pod type * add fixed proof string tests * cargo clippy * remove println's * update `assert!` and `.is_ok()` with `unwrap`'s
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This test,
test_replaypasses consistently when the test suite is run with asingle thread. It fails consistently on MacOS when run as part
of the unit-test suite.
No idea why it passes in CI.
Summary of Changes
Move the test to the integration tests