This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Unblock Testnet. Create a new status cache every second worth of ticks. #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orth of ticks gets registered
aeyakovenko
commented
Feb 16, 2019
| @@ -51,6 +51,6 @@ fn bench_process_transaction(bencher: &mut Bencher) { | |||
| // Since benchmarker runs this multiple times, we need to clear the signatures. | |||
| bank.clear_signatures(); | |||
| let results = bank.process_transactions(&transactions); | |||
| assert!(results.iter().all(Result::is_ok)); | |||
| results.iter().for_each(|r| assert_eq!(*r, Ok(()))); | |||
There was a problem hiding this comment.
this is way easier to debug
Codecov Report
@@ Coverage Diff @@
## master #2774 +/- ##
========================================
+ Coverage 78.6% 78.7% +<.1%
========================================
Files 115 115
Lines 19408 19434 +26
========================================
+ Hits 15270 15305 +35
+ Misses 4138 4129 -9 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2774 +/- ##
========================================
+ Coverage 78.6% 78.7% +<.1%
========================================
Files 115 115
Lines 19408 19434 +26
========================================
+ Hits 15270 15305 +35
+ Misses 4138 4129 -9 |
aeyakovenko
changed the title
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Sep 5, 2024
…2774) * assert refcount = 0 for zero lamport 1 refcount deletes * add test to covert zero accounts shrink unrefassert0 * fix a test * comments * add info to assert * pr changes * log instead of assert * update assert message * Update accounts-db/src/accounts_index.rs Co-authored-by: Brooks <brooks@prumo.org> --------- Co-authored-by: HaoranYi <haoran.yi@anza.xyz> Co-authored-by: HaoranYi <219428+HaoranYi@users.noreply.github.com> Co-authored-by: Brooks <brooks@prumo.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Status cache is designed for only 1 second worth of signatures. Right now the bank just keeps a single one for the lifetime. This should be fixed by proper forking, but in the meantime this allows the bank to move forward.
Summary of Changes
Create a new status cache every second. It becomes a "root" cache, which means it maintains the history of the previous caches internally.
Fixes #