This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Handling snapshot requests is now required #27537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
epoch-accounts-hash/always-handle-snapshot-requests2
branch
from
0a31b95 to
87c9b89
Compare
brooksprumo
added
CI
brooksprumo
force-pushed
the
epoch-accounts-hash/always-handle-snapshot-requests2
branch
from
87c9b89 to
1a0b5af
Compare
brooksprumo
deleted the
epoch-accounts-hash/always-handle-snapshot-requests2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For Epoch Accounts Hash support, more background services will be required to run, which are currently optional. Specifically, the current snapshot requests will also be used to handle non-optional Epoch Accounts Hash Calculation requests. So this channel is required and so is Accounts Hash Verifier.
Building on PR #27508, since the snapshot request handler will now also accept requests for Epoch Accounts Hash calculations, it no longer is optional.
Summary of Changes
The
SnapshotRequestHandlerinAbsRequestHandlersis no longer optional.