Add off-chain messages support #27456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askibin
force-pushed
the
offchain-message
branch
7 times, most recently
from
08f123d to
aa52c1c
Compare
askibin
changed the title
askibin
force-pushed
the
offchain-message
branch
2 times, most recently
from
edc8903 to
91473a9
Compare
|
just realizing i haven't finished addressing the final open issues in the spec. i'll try to wrap that up today |
askibin
force-pushed
the
offchain-message
branch
2 times, most recently
from
53fbd75 to
2d8bbef
Compare
| impl OffchainMessage { | ||
| pub const SIGNING_DOMAIN: &'static [u8] = b"\xffsolana offchain"; | ||
| // Header Length = Signing Domain (16) + Header Version (1) | ||
| pub const HEADER_LEN: usize = Self::SIGNING_DOMAIN.len() + 1; |
There was a problem hiding this comment.
const_assert_eq! here?
askibin
force-pushed
the
offchain-message
branch
from
197c171 to
d29b2e8
Compare
askibin
force-pushed
the
offchain-message
branch
from
d29b2e8 to
a240a94
Compare
askibin
force-pushed
the
offchain-message
branch
from
a240a94 to
5f95b3e
Compare
CriesofCarrots
approved these changes
Oct 14, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#21366
Summary of Changes
Adds signing of non-transaction messages with a Solana wallet. This feature can be used to authenticate users or provide proof of wallet ownership.
See Docs for more details.
In accordance with the Proposal.
Off-chain messages can be signed and verfied using Solana CLI and any of the supported wallets including Ledger. Latest firmware and Solana Ledger App v1.3.0 or higher is required for this feature to work.
Fixes #