Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Switch concurrent replay from feature to param #27401

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

bw-solana
Copy link
Contributor

@bw-solana bw-solana commented Aug 25, 2022

Problem

Concurrent slot replay has been merged (ref: #26465) but is currently not active and controlled by a feature switch. Feature switch is unnecessary in this case, and parameter would allow some set of validators to opt in to testing this capability.

Summary of Changes

Add replay_slots_concurrently parameter to enable replaying of slots from different forks concurrently during replay stage.

@bw-solana bw-solana marked this pull request as ready for review August 25, 2022 20:36
@bw-solana bw-solana requested review from carllin and mvines August 25, 2022 20:37
@carllin
Copy link
Contributor

carllin commented Aug 26, 2022

Could we also delete concurrent_replay_of_forks from bank.rs and the features from feature_set.rs?

@bw-solana
Copy link
Contributor Author

Confirmed things are behaving as expected when passing --replay-slots-concurrently (and not):

[2022-08-26T16:42:24.107844950Z WARN  solana_core::replay_stage] BWLOG: 2 active bank(s) to replay: [147596255, 147596280] - replay_slots_concurrently = true
[2022-08-26T16:42:24.209024789Z WARN  solana_core::replay_stage] BWLOG: 2 active bank(s) to replay: [147596255, 147596280] - replay_slots_concurrently = true
[2022-08-26T16:42:24.425800993Z WARN  solana_core::replay_stage] BWLOG: 2 active bank(s) to replay: [147596255, 147596281] - replay_slots_concurrently = true
[2022-08-26T16:42:24.580161181Z WARN  solana_core::replay_stage] BWLOG: 1 active bank(s) to replay: [147596282] - replay_slots_concurrently = true
[2022-08-26T16:42:24.799247359Z WARN  solana_core::replay_stage] BWLOG: 1 active bank(s) to replay: [147596283] - replay_slots_concurrently = true
[2022-08-26T16:42:24.970696365Z WARN  solana_core::replay_stage] BWLOG: 0 active bank(s) to replay: [] - replay_slots_concurrently = true
[2022-08-26T16:42:24.971277319Z WARN  solana_core::replay_stage] BWLOG: 0 active bank(s) to replay: [] - replay_slots_concurrently = true
[2022-08-26T16:42:25.072083812Z WARN  solana_core::replay_stage] BWLOG: 0 active bank(s) to replay: [] - replay_slots_concurrently = true
[2022-08-26T16:42:25.175823842Z WARN  solana_core::replay_stage] BWLOG: 1 active bank(s) to replay: [147596284] - replay_slots_concurrently = true

@bw-solana bw-solana merged commit 46a4876 into solana-labs:master Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants