Enable QUIC client by default. Add arg to disable QUIC client.

[willhickey]

Problem

• As of v1.10.32 the validator listens for QUIC connections by default
• The validator can forward transactions via quic if run with --tpu-use-quic, but doesn't by default

Summary of Changes

• Switch the default client behavior to use QUIC
• Add argument to disable the quic client

[sakridge]

thanks!

[pgarg66]

Looks like test_connection_cache is failing due to a bug in the test. It's failing specifically when QUIC is enabled.

The test creates a list of IPAddresses (and ports), creates connections using the addresses, and then looks up the table using address as the key. With QUIC, we are adding an offset (6) to the port. So the key (address/port) in the table is different than what the test had created.

Looking up 215.131.162.105:80
First entry in the table: 215.131.162.105:86

Maybe the test can be disabled as part of this PR, and an issue can be created to fix the test as a follow up PR?

Pull request has been modified.

[behzadnouri]

@willhickey Seems like this commit is causing these two tests to timeout in coverage CI:

banking_stage::tests::test_forwarder_budget
banking_stage::tests::test_handle_forwarding

The CI was also failing:
https://buildkite.com/solana-labs/solana/builds/78901

[pgarg66]

I briefly looked at these two tests. The receiver for the forwarded transactions is UDP based (in the tests). Since now we are using QUIC for forwarding the transaction, nothing is received on the UDP port, and it waits for ever.

                recv_socket
                    .set_nonblocking(expected_num_forwarded == 0)
                    .unwrap();

                let mut packets = vec![Packet::default(); 2];
                let num_received = recv_mmsg(recv_socket, &mut packets[..]).unwrap_or_default();

The solution will be start a QUIC streamer on the receiver port, and use the channel provided to the streamer to receive the packets.

[behzadnouri]

@willhickey I see that in #26912 you are commenting out the tests.

There is no tracking issues to fix those tests and you commenting them out prevents compile time checks that code still compiles.

• Can you please instead of commenting out tests use #[ignore] so that the code is at least compile checked?
• Can you please open a tracking issue to fix the test if you are ignoring tests?

[behzadnouri]

This commit also broke:

cli::tests::test_cli_parse_dos_valid_signatures

[willhickey]

This commit also broke:

cli::tests::test_cli_parse_dos_valid_signatures

Yeah... there are a bunch of broken tests.

PR #26913 has landed to revert this so CI should be unblocked. I'll work on cleaning up the tests and open a new PR