This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add size_of const fns for upgradeable loader states #25131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
approved these changes
May 11, 2022
| @@ -17,11 +17,11 @@ pub fn parse_bpf_upgradeable_loader( | |||
| UpgradeableLoaderState::Uninitialized => BpfUpgradeableLoaderAccountType::Uninitialized, | |||
| UpgradeableLoaderState::Buffer { authority_address } => { | |||
| let offset = if authority_address.is_some() { | |||
| UpgradeableLoaderState::buffer_data_offset().unwrap() | |||
There was a problem hiding this comment.
somehow if possible, keeping the offset terminology would probably be more readable at call-sites.
(i.e. not immediately clear why the caller should care about metadata or size of structs here)
There was a problem hiding this comment.
Yeah, you're definitely right. I think I would like to abstract this all away from the decoder in a follow up PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The functions for returning the length of various upgradeable loader states are expensive and fallible.
Summary of Changes
Add new
const fnmethods to make size checks inexpensive and infallibleFixes #