Revert etcd-client bump #25003
Merged
Revert etcd-client bump #25003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
revert-etcd-client-bump
branch
from
0decb03
to
075f6d4
Compare
|
Do you mind kicking |
I don't mind, but the original PR didn't touch that lock file. What would you like me to change there? |
It is out of sync with the main workspace |
CriesofCarrots
force-pushed
the
revert-etcd-client-bump
branch
from
075f6d4
to
34380bc
Compare
|
Ah got it. Odd that the checks CI job didn't care about that. |
jstarry
approved these changes
May 5, 2022
Yeah I think they check that on master, not sure why v1.9 allows it |
CriesofCarrots
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rpc nodes are seeing rpc-service stalls on v1.9.15+. Haven't totally pinned down the reason yet, but the stalls don't occur with the etcd-client bump from #24159 reverted
Summary of Changes
Revert that dependency bump
The commits are verbose because i decided the easiest way to ensure the proper things were backed out was to revert the whole 24159 commit and redo the bumps we want to preserve.