This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Define const fn StakeState::size_of for stake account size
#24416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
previously approved these changes
Apr 18, 2022
There was a problem hiding this comment.
lgtm but perhaps a const fn serialized_size in StakeState would be better.
Similar to #24435
jstarry
force-pushed
the
add-stake-size-const
branch
from
3cca739 to
dc0cc89
Compare
mergify
bot
dismissed
behzadnouri’s stale review
Pull request has been modified.
jstarry
changed the title
STAKE_ACCOUNT_SIZE constant
Yeah, that's better, thanks! |
jstarry
force-pushed
the
add-stake-size-const
branch
from
dc0cc89 to
a283dab
Compare
jstarry
changed the title
StakeState::size_of for stake account size
Codecov Report
@@ Coverage Diff @@
## master #24416 +/- ##
=======================================
Coverage 70.0% 70.0%
=======================================
Files 36 36
Lines 2255 2257 +2
Branches 322 322
=======================================
+ Hits 1580 1582 +2
Misses 560 560
Partials 115 115 |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's not obvious what the enforced size of a stake account is
Summary of Changes
StakeState::serialized_size()to use in place ofsize_of::<StakeState>()Fixes #