Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add transaction update error to Geyser plugin interface #24140

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add transaction update error to Geyser plugin interface #24140

merged 1 commit into from
Apr 6, 2022

Conversation

fardream
Copy link
Contributor

@fardream fardream commented Apr 6, 2022

Problem

Geyser plugin interface only supports errors for slot status update and account update. This PR adds support for transaction update error.

Summary of Changes

Add one more enum variant TransactionUpdateError to Geyser plugin's error enum.

@mergify mergify bot added the community Community contribution label Apr 6, 2022
@mergify mergify bot requested a review from a team April 6, 2022 13:22
@t-nelson
Copy link
Contributor

t-nelson commented Apr 6, 2022

i don't see where this is actually emitted or responded to by the streamer interface. Sounds like it's purely your implementation detail? If that's the case, please just use GesyerPluginError::Custom

@fardream
Copy link
Contributor Author

fardream commented Apr 6, 2022

i don't see where this is actually emitted or responded to by the streamer interface. Sounds like it's purely your implementation detail? If that's the case, please just use GesyerPluginError::Custom

I am following the example here in the Postgres DB plugin.

I think the error should be emitted when notify_transaction fails - looks like right now the Postgres DB plugin emits SlotUpdateError.

@lijunwangs
Copy link
Contributor

i don't see where this is actually emitted or responded to by the streamer interface. Sounds like it's purely your implementation detail? If that's the case, please just use GesyerPluginError::Custom

I am following the example here in the Postgres DB plugin.

I think the error should be emitted when notify_transaction fails - looks like right now the Postgres DB plugin emits SlotUpdateError.

Yes. I think it is desirable to make this symmetric to the other major data we are streaming

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #24140 (75723da) into master (2da4e3e) will decrease coverage by 0.1%.
The diff coverage is 79.8%.

@@            Coverage Diff            @@
##           master   #24140     +/-   ##
=========================================
- Coverage    81.8%    81.6%   -0.2%     
=========================================
  Files         581      590      +9     
  Lines      158312   161219   +2907     
=========================================
+ Hits       129518   131659   +2141     
- Misses      28794    29560    +766     

@lijunwangs lijunwangs merged commit 7ee1edd into solana-labs:master Apr 6, 2022
mergify bot pushed a commit that referenced this pull request Apr 6, 2022
CriesofCarrots pushed a commit that referenced this pull request Apr 18, 2022
mergify bot added a commit that referenced this pull request Apr 18, 2022
…4156)

(cherry picked from commit 7ee1edd)

Co-authored-by: Chao Xu <fardream@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants