Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Remove clippy override for cyclomatic complexity #2392

Merged
merged 3 commits into from
Jan 12, 2019

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Jan 11, 2019

Problem

The code is suppressing clippy warning for increased cyclomatic complexity

Summary of Changes

Remove the override, and fix the cause of increased complexity.

Fixes #2056

@pgarg66 pgarg66 requested review from mvines and rob-solana January 11, 2019 22:40
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #2392 into master will decrease coverage by 6.2%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #2392     +/-   ##
========================================
- Coverage    73.9%   67.7%   -6.3%     
========================================
  Files         110     110             
  Lines       17139   18723   +1584     
========================================
- Hits        12679   12678      -1     
- Misses       4460    6045   +1585

1 similar comment
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #2392 into master will decrease coverage by 6.2%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #2392     +/-   ##
========================================
- Coverage    73.9%   67.7%   -6.3%     
========================================
  Files         110     110             
  Lines       17139   18723   +1584     
========================================
- Hits        12679   12678      -1     
- Misses       4460    6045   +1585

Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module still sucks, but this PR takes it a long way to being maintainable again, thanks. If we were to add unit tests for all these new functions, it's clear they wouldn't be written this way (i.e. exit(1);).

@pgarg66 pgarg66 merged commit 1724430 into solana-labs:master Jan 12, 2019
@pgarg66 pgarg66 deleted the enclave branch January 12, 2019 00:49
tao-stones added a commit to tao-stones/solana that referenced this pull request Aug 1, 2024
…cy (solana-labs#2392)

refactor: move process_compute_budget_instructions from solana_compute_budget to solana_runtime_transaction, to break circular dependencies. Issue solana-labs#2169
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower cyclomatic complexity for bin/fullnode main()
2 participants